Maybe I’m not understanding the issue. Are you saying that the solution you referred to above doesn’t work for test fragments? If so, I’d be happy to take a look and see if I can figure something out. I’m currently on vacation, but I’m back next week.

Thanks for the tip and for contributing the solution!

— Patrick

One problem with this approach is that it’s easy to accidentally skip tests if OSGi fails to load a test plug-in. I wrote a quick thing that looks at the list of bundles, and finds any that end in “.tests” and are in the “INSTALLED” state, and complains about them. INSTALLED is bad because plug-ins and fragments need to be a step further, at RESOLVED, before they’re usable.

https://gist.github.com/1439941

It uses tap4j to create a file that lists any missing bundles—that part can be taken out easily if you don’t want it. I use it with the TAP plug-in for Jenkins, the missing bundles show up as failing tests.

Thanks for this tool, it’s very useful!
-Thomas

The bundle test collector can run non-OSGi unit tests just fine, but the tests will run inside of an OSGi container. This can cause issues depending on how your unit tests are structured. For example, if your unit tests are in a separate bundle, they can only access exported packages in the bundle under test. You may also have issues accessing non-public class members.

Basically, you may encounter any of the problems that commonly occur when you run non-OSGi code inside of an OSGi container…

— Patrick

– cut here –
package my.package

import java.io.File;
import java.io.UnsupportedEncodingException;
import java.lang.reflect.Modifier;
import java.net.URLDecoder;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;

import org.apache.log4j.Logger;
import org.junit.runners.model.InitializationError;
import org.junit.runner.Description;
import org.junit.runner.RunWith;
import org.junit.runner.notification.RunListener;
import org.junit.runner.notification.RunNotifier;
import org.junit.runners.Suite;

/**
* Discovers all JUnit tests and runs them in a suite.
*/
@RunWith(AllTests.AllTestsRunner.class)
public final class AllTests {

private static final File CLASSES_DIR = findClassesDir();

private AllTests() {
// static only
}

/**
* Finds and runs tests.
*/
public static class AllTestsRunner extends Suite {

private final Logger _log = Logger.getLogger(getClass());

/**
* Constructor.
*
* @param clazz the suite class – AllTests
* @throws InitializationError if there’s a problem
* @throws org.junit.runners.model.InitializationError
*/
public AllTestsRunner(final Class clazz) throws InitializationError {
super(clazz, findClasses());
}

/**
* {@inheritDoc}
* @see org.junit.runners.Suite#run(org.junit.runner.notification.RunNotifier)
*/
@Override
public void run(final RunNotifier notifier) {
initializeBeforeTests();

notifier.addListener(new RunListener() {
@Override
public void testStarted(final Description description) {
if (_log.isTraceEnabled()) {
_log.trace(“Before test ” + description.getDisplayName());
}
}

@Override
public void testFinished(final Description description) {
if (_log.isTraceEnabled()) {
_log.trace(“After test ” + description.getDisplayName());
}
}
});

super.run(notifier);
}

private static Class[] findClasses() {
List classFiles = new ArrayList();
findClasses(classFiles, CLASSES_DIR);
List<Class> classes = convertToClasses(classFiles, CLASSES_DIR);
return classes.toArray(new Class[classes.size()]);
}

private static void initializeBeforeTests() {
// do one-time initialization here
}

private static List<Class> convertToClasses(
final List classFiles, final File classesDir) {

List<Class> classes = new ArrayList<Class>();
for (File file : classFiles) {
if (!file.getName().endsWith(“Test.class”)) {
continue;
}
String name = file.getPath().substring(classesDir.getPath().length() + 1)
.replace(‘/’, ‘.’)
.replace(‘\\’, ‘.’);
name = name.substring(0, name.length() – 6);
Class c;
try {
c = Class.forName(name);
}
catch (ClassNotFoundException e) {
throw new AssertionError(e);
}
if (!Modifier.isAbstract(c.getModifiers())) {
classes.add(c);
}
}

// sort so we have the same order as Ant
Collections.sort(classes, new Comparator<Class>() {
public int compare(final Class c1, final Class c2) {
return c1.getName().compareTo(c2.getName());
}
});

return classes;
}

private static void findClasses(final List classFiles, final File dir) {
for (File file : dir.listFiles()) {
if (file.isDirectory()) {
findClasses(classFiles, file);
}
else if (file.getName().toLowerCase().endsWith(“.class”)) {
classFiles.add(file);
}
}
}
}

private static File findClassesDir() {
try {
String path = AllTests.class.getProtectionDomain()
.getCodeSource().getLocation().getFile();
return new File(URLDecoder.decode(path, “UTF-8″));
}
catch (UnsupportedEncodingException impossible) {
// using default encoding, has to exist
throw new AssertionError(impossible);
}
}
}

– cut here –

Still no luck. I’ve also tested with Eclipse 3.5.1 and it doesn’t work there either. I just left a comment on the Bugzilla entry to see if there’s anything we can do to get this working.

https://bugs.eclipse.org/181508

If you’re really interested in this, you may want to comment on the Bugzilla entry too.

— Patrick